[PATCH] D130675: [RFC][DAG] Match select of constant equivalents in foldBinOpIntoSelect.

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 28 06:12:56 PDT 2022


RKSimon added inline comments.


================
Comment at: llvm/test/CodeGen/X86/memcmp-more-load-pairs-x32.ll:165
+; X86-NEXT:    movl $-1, %eax
+; X86-NEXT:    cmovael %ecx, %eax
 ; X86-NEXT:    popl %esi
----------------
deadalnix wrote:
> @RKSimon Is this an improvement or a regression? Or it doesn't matter?
Avoiding cmov for similar codesize is usually a win - they can't be predicted and have tight eflags dependencies


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130675/new/

https://reviews.llvm.org/D130675



More information about the llvm-commits mailing list