[PATCH] D130121: [3/3] [COFF] Emit embedded -exclude-symbols: directives for hidden visibility for MinGW

Mateusz MikuĊ‚a via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 28 05:44:32 PDT 2022


mati865 added a comment.

> As the patches to LLD would be landed before, that's probably fine as long as a user doesn't update Clang without updating LLD.

For MSYS2 it's unsupported scenario so I don't fear it.

> Do you want any more investigation into the breakage risk here?

I'm away right now but even when I'm back I strongly doubt I'll have time to test it.
I think fixing builds will be trivial (using `sed`) while waiting for upstreams to release fixed versions so it should be good to go.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130121/new/

https://reviews.llvm.org/D130121



More information about the llvm-commits mailing list