[PATCH] D130121: [3/3] [COFF] Emit embedded -exclude-symbols: directives for hidden visibility for MinGW

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added a comment.

In D130121#3666011 <https://reviews.llvm.org/D130121#3666011>, @mati865 wrote:

> I'm a little bit concerned this could break some projects in the wild but for projects that use it properly this sounds like huge win (as your LLVM results show).

Do you want any more investigation into the breakage risk here? I don’t really know of any other good ways of doing that, other than including the patch in msys2’s Clang and rebuilding packages… In any case, if there’s breakage, it should be caused by inconsistent use of visibility attributes, which hopefully is easy to fix.

@rnk - can I get your opinion on this one too?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130121/new/

https://reviews.llvm.org/D130121