[PATCH] D129846: [CodeView] Add function to get size in bytes for a TypeIndex.

[Carlos Alberto Enciso via Phabricator via llvm-commits]

CarlosAlbertoEnciso added inline comments.


================
Comment at: llvm/lib/DebugInfo/CodeView/TypeRecordHelpers.cpp:54
+
+uint64_t llvm::codeview::getSizeInBytes(TypeIndex TI) {
+  if (!TI.isSimple())
----------------
rnk wrote:
> These two methods have the same name but appear to do different things: The TypeIndex version returns sizeof(T), and the CVType version returns the size of the CVType record. Should they be named differently?
Good point.

Suggested names:
- The `TypeIndex` version --> `getSizeInBytesForTypeIndex`
- The `CVType` version --> `getSizeInBytesForTypeRecord`



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129846/new/

https://reviews.llvm.org/D129846