[PATCH] D129846: [CodeView] Add function to get size in bytes for a TypeIndex.
Reid Kleckner via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jul 26 09:32:04 PDT 2022
rnk added inline comments.
================
Comment at: llvm/lib/DebugInfo/CodeView/TypeRecordHelpers.cpp:54
+
+uint64_t llvm::codeview::getSizeInBytes(TypeIndex TI) {
+ if (!TI.isSimple())
----------------
These two methods have the same name but appear to do different things: The TypeIndex version returns sizeof(T), and the CVType version returns the size of the CVType record. Should they be named differently?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D129846/new/
https://reviews.llvm.org/D129846
More information about the llvm-commits
mailing list