[PATCH] D130034: [BOLT] Add BinaryContext::IsStripped

[Amir Ayupov via Phabricator via llvm-commits]

Amir requested changes to this revision.
Amir added a comment.
This revision now requires changes to proceed.

I'm requesting changes because the user-facing message needs to be updated. Please also update the test accordingly.



================
Comment at: bolt/lib/Rewrite/RewriteInstance.cpp:1640
+  if (BC->IsStripped)
+    outs() << "BOLT-INFO: target binary is stripped!\n";
+
----------------



================
Comment at: bolt/test/X86/is-strip.s:2
+# This reproduces a bug with jump table identification where jump table has
+# entries pointing to code in function and its cold fragment.
+
----------------
Please update the summary.


================
Comment at: bolt/test/X86/is-strip.s:6
+
+# RUN: %clang++ %p/Inputs/gcd.cpp -o %t -Wl,-q
+# RUN: llvm-bolt %t -o %t.out 2>&1 | FileCheck %s -check-prefix=CHECK-NOSTRIP
----------------
I would prefer reusing some existing input source that doesn't require system-linux to make this test as general as possible.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130034/new/

https://reviews.llvm.org/D130034