[PATCH] D130047: [RISCV] Disable constant hoisting for multiply by negated power of 2.

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 27 07:57:51 PDT 2022


reames accepted this revision.
reames added a comment.
This revision is now accepted and ready to land.

LGTM

However, I'll note the code structure here is non-obvious.  When I see code talking about immediate cost, I don't expect that to be highly specific to hoisting.  I expect it to instead relate to materialization cost.  And yet, that doesn't appear to be what the existing code in this method does.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130047/new/

https://reviews.llvm.org/D130047



More information about the llvm-commits mailing list