[PATCH] D130592: [IR] Move support for dxil::TypedPointerType to LLVM core IR.

Wed Jul 27 07:54:17 PDT 2022

jcranmer-intel marked 2 inline comments as done.
jcranmer-intel added inline comments.

================
Comment at: llvm/lib/IR/AsmWriter.cpp:614
+  case Type::TypedPointerTyID:
+    OS << "typedptr (" << Ty << ")";
     return;
----------------
nikic wrote:
> nikic wrote:
> > If it's useful for debugging, you could also include TypedPointerType.h here and print `*cast<TypedPointerType>(Ty->getElementType())`, instead of printing the address of the type.
> I believe this is missing an `*`, you're currently printing the address of the element type.
Just noticed it right before you wrote that comment, I'm embarrassed to have not caught it earlier. :-(

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130592/new/

https://reviews.llvm.org/D130592