[PATCH] D130592: [IR] Move support for dxil::TypedPointerType to LLVM core IR.

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 27 07:50:43 PDT 2022


nikic added inline comments.


================
Comment at: llvm/lib/IR/AsmWriter.cpp:614
+  case Type::TypedPointerTyID:
+    OS << "typedptr (" << Ty << ")";
     return;
----------------
nikic wrote:
> If it's useful for debugging, you could also include TypedPointerType.h here and print `*cast<TypedPointerType>(Ty->getElementType())`, instead of printing the address of the type.
I believe this is missing an `*`, you're currently printing the address of the element type.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130592/new/

https://reviews.llvm.org/D130592



More information about the llvm-commits mailing list