[PATCH] D122255: Meta directive runtime support

[Abid via Phabricator via llvm-commits]

abidmalikwaterloo marked 4 inline comments as done.
abidmalikwaterloo added inline comments.


================
Comment at: clang/include/clang/AST/RecursiveASTVisitor.h:3144
+    for (const OMPTraitSelector &Selector : Set.Selectors) {
+      if (Selector.Kind == llvm::omp::TraitSelector::user_condition &&
+          Selector.ScoreOrCondition)
----------------
If it is not the user's condition or score then what will happen?


================
Comment at: clang/lib/Sema/SemaOpenMP.cpp:7439
+      }
+    }
+
----------------
abidmalikwaterloo wrote:
> jdoerfert wrote:
> > Why does this perform partial trait matching? We should have code for this. Also, the logic for device_arch and vendor (which is most what there is), is not what we want. Reuse the existing matching logic instead.
> Ok. What do you mean by `existing matching logic`? 
@jdoerfert I agree that the implementation is incomplete in terms of trait matching. It can be completed. However, I am not clear about your comments about the `existing matching logic`.  I checked OMPContext.CPP and other files. There are functions that can be used to match the traits. But, I could not find any existing logic that can be used here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122255/new/

https://reviews.llvm.org/D122255