[PATCH] D112256: [FPEnv][EarlyCSE] Add support for CSE of constrained FP intrinsics, take 2

[Sanjay Patel via Phabricator via llvm-commits]

spatel added a comment.

In D112256#3677330 <https://reviews.llvm.org/D112256#3677330>, @kpn wrote:

> You know, I now believe that I can simplify this down to just this. The complication to treat constrained intrinsics as a memory update was put in when I added the restrictions on doing CSE across function calls. But since that restriction isn't needed I don't see the need for the rest of the complications. I don't think we need to go to heroics just for exception handlers, at least not at this time. This code is now much simpler.

That is a lot neater. :)
I'm still not sure what you're trying to show in that last test file. It should be fine to pre-commit the tests with baseline results now (that might help highlight a diff?).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112256/new/

https://reviews.llvm.org/D112256