[PATCH] D112256: [FPEnv][EarlyCSE] Add support for CSE of constrained FP intrinsics, take 2

Kevin P. Neal via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 25 13:22:14 PDT 2022


kpn updated this revision to Diff 447448.
kpn added a comment.

You know, I now believe that I can simplify this down to just this. The complication to treat constrained intrinsics as a memory update was put in when I added the restrictions on doing CSE across function calls. But since that restriction isn't needed I don't see the need for the rest of the complications. I don't think we need to go to heroics just for exception handlers, at least not at this time. This code is now much simpler.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112256/new/

https://reviews.llvm.org/D112256

Files:
  llvm/lib/Transforms/Scalar/EarlyCSE.cpp
  llvm/test/Transforms/EarlyCSE/ebstrict-strictfp.ll
  llvm/test/Transforms/EarlyCSE/mixed-strictfp.ll
  llvm/test/Transforms/EarlyCSE/nonmixed-strictfp.ll
  llvm/test/Transforms/EarlyCSE/round-dyn-strictfp.ll
  llvm/test/Transforms/EarlyCSE/tfpropagation.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D112256.447448.patch
Type: text/x-patch
Size: 88825 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220725/30048b6f/attachment-0001.bin>


More information about the llvm-commits mailing list