[PATCH] D129952: [ORC][COFF] Handle COFF import files of static archive.

[Lang Hames via Phabricator via llvm-commits]

lhames accepted this revision.
lhames added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/tools/llvm-jitlink/llvm-jitlink.cpp:1665-1667
+    for (auto FileName : (*G)->getImportedDynamicLibraries())
+      if (auto Err = S.loadDynamicLibrary(FileName))
+        return std::move(Err);
----------------
sunho wrote:
> lhames wrote:
> > This is always going to load the library as a real dylib (via EPCDynamicLibrarySearchGenerator), right?
> > 
> > Could we have it treated as if it were a `-L` argument instead?
> We want to search the dll file that is not inside specified -L serach directories as well. One way is extend existing -l flag to also look up system dynamic library if everything else fails in search directorires and print warning message. How does that sound to you?
How is MSVC / LINK.EXE handling this? Do they just have a fallback list of search paths to search on? I'd be fine with including those as if they were `-L` arguments by default (maybe with a switch to turn them off explicitly where they're not wanted)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129952/new/

https://reviews.llvm.org/D129952