[PATCH] D129952: [ORC][COFF] Handle COFF import files of static archive.

Sunho Kim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 25 08:32:21 PDT 2022


sunho added inline comments.


================
Comment at: llvm/tools/llvm-jitlink/llvm-jitlink.cpp:1665-1667
+    for (auto FileName : (*G)->getImportedDynamicLibraries())
+      if (auto Err = S.loadDynamicLibrary(FileName))
+        return std::move(Err);
----------------
lhames wrote:
> This is always going to load the library as a real dylib (via EPCDynamicLibrarySearchGenerator), right?
> 
> Could we have it treated as if it were a `-L` argument instead?
We want to search the dll file that is not inside specified -L serach directories as well. One way is extend existing -l flag to also look up system dynamic library if everything else fails in search directorires and print warning message. How does that sound to you?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129952/new/

https://reviews.llvm.org/D129952



More information about the llvm-commits mailing list