[PATCH] D130359: [llvm-objdump, ARM] Make dumpARMELFData line up with instructions.

Mon Jul 25 07:59:27 PDT 2022

simon_tatham added a comment.

In D130359#3676245 <https://reviews.llvm.org/D130359#3676245>, @DavidSpickett wrote:

> Makes me wonder if .word should also print the bytes together like you're changing instructions to do but that's a separate thing.

I agree that it's separate. In particular, that's data rather than code, so you //do// have to pay attention to endianness, and I wasn't sure if it would get confusing in a big-endian disassembly to have code and data lines right next to each other both showing 32-bit hex numbers which are //implicitly// representing the contents of memory in conflicting endiannesses!

================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:1019
+  AlignToInstStartColumn(Start, STI, OS);
+  OS << "\t.byte\t" << format_hex(Bytes[0], 4);
   return 1;
----------------
DavidSpickett wrote:
> This becomes `Bytes[Index]` when you rebase to include https://reviews.llvm.org/D130360 I assume.
Yes, I reordered the patches because D130360 got review attention first, and haven't rebased this one yet.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130359/new/

https://reviews.llvm.org/D130359