[PATCH] D130359: [llvm-objdump, ARM] Make dumpARMELFData line up with instructions.

[David Spickett via Phabricator via llvm-commits]

DavidSpickett accepted this revision.
DavidSpickett added a comment.
This revision is now accepted and ready to land.

LGTM

Makes me wonder if .word should also print the bytes together like you're changing instructions to do but that's a separate thing.

  $ objdump -d /tmp/test.o
  <...>
     0:   cafef00d        .word   0xcafef00d
  $ ./bin/llvm-objdump -d /tmp/test.o
  <...>
  0000000000000000 <fn>:
         0:       0d f0 fe ca     .word   0xcafef00d



================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:1019
+  AlignToInstStartColumn(Start, STI, OS);
+  OS << "\t.byte\t" << format_hex(Bytes[0], 4);
   return 1;
----------------
This becomes `Bytes[Index]` when you rebase to include https://reviews.llvm.org/D130360 I assume.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130359/new/

https://reviews.llvm.org/D130359