[PATCH] D127115: [RFC][DAGCombine] Make sure combined nodes are added back to the worklist in topological order.

Sun Jul 24 08:50:35 PDT 2022

deadalnix added a comment.

In D127115#3674466 <https://reviews.llvm.org/D127115#3674466>, @RKSimon wrote:

> OK - I /think/ that if we add MERGE_VALUES 'peek through' handling to both llvm::isNullConstant and llvm::isConstOrConstSplat then we can revert the rG2421a5af72e7da7c29fd153dcee0981deaaeba64 <https://reviews.llvm.org/rG2421a5af72e7da7c29fd153dcee0981deaaeba64> change

It's almost certainly a good thing to add, so I'll do it, but it doesn't really address the problem at hand other than superficially, as we really ought to be able to reassociate properly.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127115/new/

https://reviews.llvm.org/D127115