[PATCH] D127115: [RFC][DAGCombine] Make sure combined nodes are added back to the worklist in topological order.

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added a comment.

In D127115#3674152 <https://reviews.llvm.org/D127115#3674152>, @deadalnix wrote:

> In D127115#3674124 <https://reviews.llvm.org/D127115#3674124>, @RKSimon wrote:
>
>> Please have a go if you're interested - I've wasted ages trying to get it to work in a better way.
>
> I'm already on it, but you are indeed correct that this is more hairy that it initially looks like.

OK - I /think/ that if we add MERGE_VALUES 'peek through' handling to both llvm::isNullConstant and llvm::isConstOrConstSplat then we can revert the rG2421a5af72e7da7c29fd153dcee0981deaaeba64 <https://reviews.llvm.org/rG2421a5af72e7da7c29fd153dcee0981deaaeba64> change


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127115/new/

https://reviews.llvm.org/D127115