[PATCH] D130366: [AsmPrinter] Reject ptrtoint to larger size in lowerConstant()

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 22 16:59:58 PDT 2022


MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.

Looks great!



================
Comment at: llvm/test/CodeGen/X86/ptrtoint-constexpr-invalid.ll:1
+; RUN: not --crash llc < %s -mtriple=i386-linux 2>&1 | FileCheck %s
+
----------------
Add a file-level comment that this is intentionally unsupported.

Otherwise from `not --crash` it is usually unclear whether it is a limitation or intentional.



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130366/new/

https://reviews.llvm.org/D130366



More information about the llvm-commits mailing list