[PATCH] D120059: [sanitizer_common] Support Solaris < 11.4 in GetStaticTlsBoundary
Rainer Orth via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jul 21 00:12:38 PDT 2022
ro marked an inline comment as done.
ro added inline comments.
================
Comment at: compiler-rt/lib/sanitizer_common/sanitizer_linux_libcdep.cpp:361
+#if SANITIZER_SOLARIS
+ // With the introduction of dlpi_tls_modid, the tlsmodid of the executable
+ // was changed to 1 to match other implementations.
----------------
MaskRay wrote:
> Instead of having two chunks of comments, just have one saying that the `#if SANITIZER_SOLARIS` branch is for Solaris < 11.4 compatibility?
That's way clearer indeed.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D120059/new/
https://reviews.llvm.org/D120059
More information about the llvm-commits
mailing list