[PATCH] D120059: [sanitizer_common] Support Solaris < 11.4 in GetStaticTlsBoundary

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 20 10:50:55 PDT 2022


MaskRay accepted this revision.
MaskRay added inline comments.
This revision is now accepted and ready to land.


================
Comment at: compiler-rt/lib/sanitizer_common/sanitizer_linux_libcdep.cpp:361
+#if SANITIZER_SOLARIS
+  // With the introduction of dlpi_tls_modid, the tlsmodid of the executable
+  // was changed to 1 to match other implementations.
----------------
Instead of having two chunks of comments, just have one saying that the `#if SANITIZER_SOLARIS` branch is for Solaris < 11.4 compatibility?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120059/new/

https://reviews.llvm.org/D120059



More information about the llvm-commits mailing list