[PATCH] D129717: [VPlan] Initial def-use verification.

[Florian Hahn via Phabricator via llvm-commits]

fhahn marked 2 inline comments as done.
fhahn added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/VPlanVerifier.cpp:194
+
+        // Skip blocks outside any region for now
+        auto *ParentR = VPBB->getParent();
----------------
Ayal wrote:
> nit: can early-continue/skip blocks in non-replicating regions.
Simplified in the committed version, thanks!


================
Comment at: llvm/lib/Transforms/Vectorize/VPlanVerifier.cpp:233
   auto Iter = depth_first(
       VPBlockRecursiveTraversalWrapper<const VPBlockBase *>(Plan.getEntry()));
   for (const VPBasicBlock *VPBB :
----------------
Ayal wrote:
> nit: can fold the two dfs traversals into one - if a VPB hasn't had its BlockNumber assigned yet, it's number is/will-be greater than any which have.
Done in the committed version, thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129717/new/

https://reviews.llvm.org/D129717