[PATCH] D130106: [LV] Fix miscompile due to srem/sdiv speculation safety condition
David Sherwood via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jul 20 00:47:55 PDT 2022
david-arm accepted this revision.
david-arm added a comment.
This revision is now accepted and ready to land.
LGTM! Nice fix. :)
================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:4465
+ // TODO: We can use the loop-preheader as context point here and get
+ // context sensetive reasoning
+ return !isSafeToSpeculativelyExecute(I);
----------------
nit: I think this should be 'sensitive'
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130106/new/
https://reviews.llvm.org/D130106
More information about the llvm-commits
mailing list