[PATCH] D128544: [Orc][JITLink] Add a shared memory based implementation of MemoryMapper

[Lang Hames via Phabricator via llvm-commits]

lhames accepted this revision.
lhames added a comment.

In D128544#3659757 <https://reviews.llvm.org/D128544#3659757>, @argentite wrote:

> Use new SharedMemorySegFinalizeRequest instead of SegFinalizeRequest
>
> The problem seems to be that there is a Content: ArrayRef<char> in SegFinalizeRequest. In SharedMemoryMapper it is set to (nullptr, 0) since we do not use it but the serialization code runs memcpy anyway with source nullptr and length 0. A new type SharedMemorySegFinalizeRequest without this field will make the intent clear as well.

I fixed serialization of empty `ArrayRef<char>` in 67220c2ad72 <https://reviews.llvm.org/rG67220c2ad72e32cea18bb261366e64fe5de75b16>, but I like the idea of a custom request type for the SharedMemoryMapper too -- I'll keep that and re-re-land this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128544/new/

https://reviews.llvm.org/D128544