[PATCH] D128544: [Orc][JITLink] Add a shared memory based implementation of MemoryMapper

[Anubhab Ghosh via Phabricator via llvm-commits]

argentite updated this revision to Diff 445496.
argentite added a comment.

Use new SharedMemorySegFinalizeRequest instead of SegFinalizeRequest

The problem seems to be that there is a Content: ArrayRef<char> in SegFinalizeRequest. In SharedMemoryMapper it is set to (nullptr, 0) since we do not use it but the serialization code runs memcpy anyway with source nullptr and length 0. A new type SharedMemorySegFinalizeRequest without this field will make the intent clear as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128544/new/

https://reviews.llvm.org/D128544

Files:
  llvm/include/llvm/ExecutionEngine/Orc/MemoryMapper.h
  llvm/include/llvm/ExecutionEngine/Orc/Shared/OrcRTBridge.h
  llvm/include/llvm/ExecutionEngine/Orc/Shared/TargetProcessControlTypes.h
  llvm/include/llvm/ExecutionEngine/Orc/TargetProcess/ExecutorSharedMemoryMapperService.h
  llvm/lib/ExecutionEngine/Orc/CMakeLists.txt
  llvm/lib/ExecutionEngine/Orc/MemoryMapper.cpp
  llvm/lib/ExecutionEngine/Orc/Shared/OrcRTBridge.cpp
  llvm/lib/ExecutionEngine/Orc/TargetProcess/CMakeLists.txt
  llvm/lib/ExecutionEngine/Orc/TargetProcess/ExecutorSharedMemoryMapperService.cpp
  llvm/unittests/ExecutionEngine/Orc/CMakeLists.txt
  llvm/unittests/ExecutionEngine/Orc/SharedMemoryMapperTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D128544.445496.patch
Type: text/x-patch
Size: 37699 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220718/180620d4/attachment-0001.bin>