[PATCH] D129084: [AMDGPU] gfx11 Fix VOP3 dot instructions

Petar Avramovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 19 13:44:12 PDT 2022


Petar.Avramovic updated this revision to Diff 445930.
Petar.Avramovic retitled this revision from "[AMDGPU] gfx11 Fix disassembler for VOP3 dpp8" to "[AMDGPU] gfx11 Fix VOP3 dot instructions".
Petar.Avramovic edited the summary of this revision.
Petar.Avramovic added a comment.

Matches sp3 behavior. op_sel[0:1] must be 0. abs and neg src modifiers for bf16
FixMe(wip, requires some td file changes) clang uses i16 for bf16, I used f16 to get abs and neg parsing support.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129084/new/

https://reviews.llvm.org/D129084

Files:
  llvm/include/llvm/IR/IntrinsicsAMDGPU.td
  llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp
  llvm/lib/Target/AMDGPU/VOP3Instructions.td
  llvm/lib/Target/AMDGPU/VOPInstructions.td
  llvm/test/CodeGen/AMDGPU/llvm.amdgcn.fdot2.bf16.bf16.ll
  llvm/test/CodeGen/AMDGPU/llvm.amdgcn.fdot2.f16.f16.ll
  llvm/test/MC/AMDGPU/gfx11_asm_dpp16.s
  llvm/test/MC/AMDGPU/gfx11_asm_dpp8.s
  llvm/test/MC/AMDGPU/gfx11_vop123.s
  llvm/test/MC/Disassembler/AMDGPU/decode-err-gfx11.txt
  llvm/test/MC/Disassembler/AMDGPU/gfx11_dasm_all.txt
  llvm/test/MC/Disassembler/AMDGPU/gfx11_dasm_vop3_dpp16.txt
  llvm/test/MC/Disassembler/AMDGPU/gfx11_dasm_vop3_dpp8.txt

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D129084.445930.patch
Type: text/x-patch
Size: 27009 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220719/a1f084af/attachment.bin>


More information about the llvm-commits mailing list