[PATCH] D129641: [DAG] PromoteIntRes_BUILD_VECTOR - extend constant boolean vectors according to target BooleanContents

[Eli Friedman via Phabricator via llvm-commits]

efriedma added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp:5271
+      unsigned ExtOpc = ISD::ANY_EXTEND;
+      // Attempt to extend constant bool vectors to match target's BooleanContent.
+      if (OpVT == MVT::i1 && Op.getOpcode() == ISD::Constant)
----------------
Please fix this comment to make it clear this is a heuristic; there isn't any semantic requirement that the high bits match getBooleanContents() here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129641/new/

https://reviews.llvm.org/D129641