[PATCH] D122791: [DAGCombiner] Teach scalarizeBinOpOfSplats handle scalable splat.

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.

LGTM with one minor



================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:23035
+  bool IsBothSplatVector = N0.getOpcode() == ISD::SPLAT_VECTOR &&
+                           N1.getOpcode() == ISD::SPLAT_VECTOR;
   if (!Src0 || !Src1 || Index0 != Index1 ||
----------------
jacquesguan wrote:
> RKSimon wrote:
> > Use DAG.isSplatValue instead?
> I tried to use DAG.isSplatValue, but this way would affect many no splat cases of X86 target, some of them are negative.
OK - please can you add a TODO comment? It sounds like something that needs revisiting in the future.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122791/new/

https://reviews.llvm.org/D122791