[PATCH] D129937: [JITLink][COFF] Handle duplicate external symbols.

[Sunho Kim via Phabricator via llvm-commits]

sunho added a comment.

@sgraenitz  I'm not exactly sure what's going on but this happens a lot when I load up microsoft stl library (msvcp.lib, libcpmt.lib) which is needed to load static orc runtime. I can dig more into why this is happening.

For collection side, maybe we should change jitlink graph to store external symbols with DenseMap instead? We must iterate over the entire external_symobls() in order to check duplicate right now. (which sounded expensive for me) I always thought we should change it to densemap but didn't proceed on as it has been invalid for object file to list symbol twice.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129937/new/

https://reviews.llvm.org/D129937