[PATCH] D129937: [JITLink][COFF] Handle duplicate external symbols.
Stefan Gränitz via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Jul 17 12:24:01 PDT 2022
sgraenitz added a comment.
Is this happening on a regular basis? Any idea why it happens?
================
Comment at: llvm/lib/ExecutionEngine/JITLink/COFFLinkGraphBuilder.cpp:229
+ &G->addExternalSymbol(SymbolName, Sym->getValue(), Linkage::Strong);
+ GSym = ExternalSymbols[SymbolName];
} else if (Sym->isWeakExternal()) {
----------------
Tracking all symbols names in new collection appears expensive. Could we check `LinkGraph::external_symbols()` instead?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D129937/new/
https://reviews.llvm.org/D129937
More information about the llvm-commits
mailing list