[PATCH] D129721: [JITLink][COFF] Handle out-of-order COMDAT second symbol.

Sunho Kim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jul 17 10:39:32 PDT 2022


sunho added inline comments.


================
Comment at: llvm/lib/ExecutionEngine/JITLink/COFFLinkGraphBuilder.cpp:523
   });
   PendingComdatExport = None;
   return Target;
----------------
sgraenitz wrote:
> Shouldn't this assign to `PendingComdatExports[Symbol.getSectionNumber()]` now?
good catch! it miraclely built succesfully as variable with the same name was introduced.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129721/new/

https://reviews.llvm.org/D129721



More information about the llvm-commits mailing list