[PATCH] D129721: [JITLink][COFF] Handle out-of-order COMDAT second symbol.

Stefan Gränitz via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jul 17 10:33:38 PDT 2022


sgraenitz added a comment.

Oh, good catch! Thanks



================
Comment at: llvm/lib/ExecutionEngine/JITLink/COFFLinkGraphBuilder.cpp:523
   });
   PendingComdatExport = None;
   return Target;
----------------
Shouldn't this assign to `PendingComdatExports[Symbol.getSectionNumber()]` now?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129721/new/

https://reviews.llvm.org/D129721



More information about the llvm-commits mailing list