[PATCH] D129557: [AMDGPU] Improve liveness copying in si-optimize-exec-masking-pre-ra

[Matt Arsenault via Phabricator via llvm-commits]

arsenm accepted this revision.
arsenm added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/Target/AMDGPU/SIOptimizeExecMaskingPreRA.cpp:227
+      assert(SelLI->getSegmentContaining(SelIdx.getRegSlot()) &&
+             "No live interval segment covering defintion?");
+      for (auto I = SelLI->FindSegmentContaining(SelIdx.getRegSlot());
----------------
critson wrote:
> arsenm wrote:
> > Typo defintion. The assert seems a bit redundant with the FindSegmentContaining below
> Fixed the typo.
> I would prefer to the keep the assertion because while the code won't fail without segment, it suggest something is wrong which will impact code gen.
I mean you could assert FindSegmentContaining isn't the end


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129557/new/

https://reviews.llvm.org/D129557