[PATCH] D129793: [LSR] Allow already invariant operand for ICmpZero matching

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 15 11:46:32 PDT 2022


reames updated this revision to Diff 445082.
reames added a comment.

Version with fix for pointer difference bug.

I think I now understand Arthur's case.  This is visit uses outside of loop L, and L->isLoopInvariant returns true for instructions outside the loop even if that instruction does not dominate L.  Going to reduce a minimal test case (to confirm theory), and then update with the second fix.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129793/new/

https://reviews.llvm.org/D129793

Files:
  llvm/lib/Transforms/Scalar/LoopStrengthReduce.cpp
  llvm/test/CodeGen/RISCV/rvv/sink-splat-operands.ll
  llvm/test/Transforms/LoopStrengthReduce/RISCV/icmp-zero.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D129793.445082.patch
Type: text/x-patch
Size: 53322 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220715/64111552/attachment.bin>


More information about the llvm-commits mailing list