[PATCH] D128180: [DebugInfo][InstrRef][NFC] Let LDV handle joins for lists of debug ops

[Stephen Tozer via Phabricator via llvm-commits]

StephenTozer added inline comments.


================
Comment at: llvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.cpp:2497
         (OutVal.Kind == DbgValue::VPHI && OutVal.BlockNo != MBB.getNumber() &&
-         !OutVal.getDbgOpID(0).isUndef())) {
-      ValueIDNum ValToLookFor = DbgOpStore.find(OutVal.getDbgOpID(0)).ID;
+         OutValOp.ID != ValueIDNum::EmptyValue)) {
+      ValueIDNum ValToLookFor = OutValOp.ID;
----------------
Orlando wrote:
> is `!OutValOp.isUndef()` the same as `OutValOp.ID != ValueIDNum::EmptyValue`? 
Basically, except we're skipping the check for IsConst here (as we assert !IsConst above) - but now that you mention it, might as well keep it the same for consistency's sake and legibility.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128180/new/

https://reviews.llvm.org/D128180