[PATCH] D128180: [DebugInfo][InstrRef][NFC] Let LDV handle joins for lists of debug ops

[Orlando Cazalet-Hyams via Phabricator via llvm-commits]

Orlando added a comment.

The additions/changes SGTM but I don't think I'd be able to catch an omission here - imo it's worth @jmorse having a quick look too.



================
Comment at: llvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.cpp:2497
         (OutVal.Kind == DbgValue::VPHI && OutVal.BlockNo != MBB.getNumber() &&
-         !OutVal.getDbgOpID(0).isUndef())) {
-      ValueIDNum ValToLookFor = DbgOpStore.find(OutVal.getDbgOpID(0)).ID;
+         OutValOp.ID != ValueIDNum::EmptyValue)) {
+      ValueIDNum ValToLookFor = OutValOp.ID;
----------------
is `!OutValOp.isUndef()` the same as `OutValOp.ID != ValueIDNum::EmptyValue`? 


================
Comment at: llvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.cpp:2535
 
+  Locs.clear();
+
----------------
Is `Locs.clear()` left over from experimental changes? (Looks redundant to me?)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128180/new/

https://reviews.llvm.org/D128180