[PATCH] D123496: [RISCV] Add Stackmap/Statepoint/Patchpoint support without targets

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 14 10:39:19 PDT 2022


craig.topper added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVAsmPrinter.cpp:16
 #include "MCTargetDesc/RISCVMCExpr.h"
+#include "MCTargetDesc/RISCVMatInt.h"
 #include "MCTargetDesc/RISCVTargetStreamer.h"
----------------
Is this used? I see the discussion about using RISCVMatInt::generateInstSeq but I don't see any code.


================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfo.cpp:998
+
+  if (Opcode == TargetOpcode::STACKMAP) {
+    // The upper bound for a stackmap intrinsic is the full length of its shadow
----------------
Use a switch?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123496/new/

https://reviews.llvm.org/D123496



More information about the llvm-commits mailing list