[PATCH] D129291: [NVPTX] Promote i24, i40, i48 and i56 to next power-of-two register when passing

Kjetil Kjeka via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 14 07:57:34 PDT 2022


kjetilkjeka updated this revision to Diff 444662.
kjetilkjeka added a comment.

I have implement your review comments.

Looking at the tests from `test/CodeGen/NVPTX/param-load-store.ll` helped a lot and I think the quality of the tests are better now.

I also discovered a bug when implementing the `i2` and `i3` test related to promoting the type to `u8` but using a `u16` as the container but it should be fixed now.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129291/new/

https://reviews.llvm.org/D129291

Files:
  llvm/lib/Target/NVPTX/NVPTXAsmPrinter.cpp
  llvm/lib/Target/NVPTX/NVPTXISelLowering.cpp
  llvm/lib/Target/NVPTX/NVPTXUtilities.h
  llvm/test/CodeGen/NVPTX/param-load-store.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D129291.444662.patch
Type: text/x-patch
Size: 20476 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220714/f11c4ccc/attachment.bin>


More information about the llvm-commits mailing list