[PATCH] D125783: [llvm-dva] 08 - ELF Reader

[Carlos Alberto Enciso via Phabricator via llvm-commits]

CarlosAlbertoEnciso added inline comments.


================
Comment at: llvm/unittests/DebugInfo/LogicalView/ELFReaderTest.cpp:243
+// Logical elements properties.
+void elementProperties(SmallString<128> &InputsDir) {
+  // Reader options.
----------------
psamolysov wrote:
> I believe this should work as well as for the `SmallVector<N>/SmallVectorImpl` pair.
I can't find a similar `SmallString<N>/SmallStringImpl` pair.


================
Comment at: llvm/unittests/DebugInfo/LogicalView/ELFReaderTest.cpp:267
+// Logical elements selection.
+void elementSelection(SmallString<128> &InputsDir) {
+  // Reader options.
----------------
psamolysov wrote:
> 
I can't find a similar `SmallString<N>/SmallStringImpl` pair.


================
Comment at: llvm/unittests/DebugInfo/LogicalView/ELFReaderTest.cpp:298
+// Compare logical elements.
+void compareElements(SmallString<128> &InputsDir) {
+  // Reader options.
----------------
psamolysov wrote:
> 
I can't find a similar `SmallString<N>/SmallStringImpl` pair.


================
Comment at: llvm/unittests/DebugInfo/LogicalView/ELFReaderTest.cpp:331
+
+  SmallString<128> InputsDir = unittest::getInputFileDirectory(TestMainArgv0);
+
----------------
psamolysov wrote:
> `SmallStringImpl InputDir` also should works but I haven't checked.
I can't find a similar `SmallString<N>/SmallStringImpl` pair.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125783/new/

https://reviews.llvm.org/D125783