[PATCH] D125744: github: Add a helpful message for issues without milestones

Konrad Wilhelm Kleine via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 11 03:28:20 PDT 2022


kwk accepted this revision.
kwk added a comment.
This revision is now accepted and ready to land.

LGTM now. Thank you for addressing the comments.



================
Comment at: llvm/utils/git/github-automation.py:163
+    def issue_notify_no_milestone(self, comment:List[str]) -> None:
+        message = "{}\n\nError: Command failed due to missing milestone.".format(''.join(['>' + line for line in comment]))
+        self.issue.create_comment(self.make_ignore_comment(message))
----------------
Not sure if this was in here before but this is a great improvement in case the comment spanned more than one line!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125744/new/

https://reviews.llvm.org/D125744



More information about the llvm-commits mailing list