[PATCH] D128968: [JITLink][COFF] Initial COFF support.

Sunho Kim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 14 04:15:23 PDT 2022


sunho added inline comments.


================
Comment at: llvm/lib/ExecutionEngine/JITLink/COFFLinkGraphBuilder.cpp:339
+      LLVM_DEBUG({
+        if (Offset + Symbol->getSize() > LastDifferentOffset)
+          dbgs() << "  Overlapping symbol range generated for the following "
----------------
sunho wrote:
> chapuni wrote:
> > LastDifferentOffset is not used with -Asserts.
> @chapuni Hi, I'll fix this shortly. Thanks for letting me know.
Fixed in https://github.com/llvm/llvm-project/commit/18a6ab5b8d1f1bd44fdd8f61785922edbeb35357. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128968/new/

https://reviews.llvm.org/D128968



More information about the llvm-commits mailing list