[PATCH] D128822: [FuncSpec] Partially revert rG8b360c69e9e3.

Thu Jul 14 00:05:33 PDT 2022

labrinea added a comment.

In D128822#3644296 <https://reviews.llvm.org/D128822#3644296>, @sinan wrote:

> The reason why test cases crash at Solver.getLatticeValueFor is that SCCPSolver does not track the lattice value of a callbase argument. However, it is doable for SCCPSolver to track the lattice value of a ConstantExpr, and that is why I think skipping ConstantExpr is not an sound solution.
>
> So, the potential problem with D126455 <https://reviews.llvm.org/D126455> is that the argument of a callbase is changed before FS, and SCCPSolver is not updated. Can you have a check on that?

Hi, thanks for the input. D126455 <https://reviews.llvm.org/D126455> is part of a patch series. Indeed if the users of a replaced value are visited then the crash doesn't happen. I am already doing this on D128825 <https://reviews.llvm.org/D128825> and D126456 <https://reviews.llvm.org/D126456>.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128822/new/

https://reviews.llvm.org/D128822