[PATCH] D128822: [FuncSpec] Partially revert rG8b360c69e9e3.

[Sinan Lin via Phabricator via llvm-commits]

sinan added a comment.

The reason why test cases crash at Solver.getLatticeValueFor is that SCCPSolver does not track the lattice value of a callbase argument. However, it is doable for SCCPSolver to track the lattice value of a ConstantExpr, and that is why I think skipping ConstantExpr is not an sound solution.

So, the potential problem with D126455 <https://reviews.llvm.org/D126455> is that the argument of a callbase is changed between IPSCCP and FS, and SCCPSolver is not updated. Can you have a check on that?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128822/new/

https://reviews.llvm.org/D128822