[PATCH] D129677: Disable machine function splitting for functions with inline asm br

Wed Jul 13 14:18:21 PDT 2022

adriantong1024 added a comment.

In D129677#3649806 <https://reviews.llvm.org/D129677#3649806>, @efriedma wrote:

>> The ones in the inline assembly cannot.
>
> This should be fixable on top of D129288 <https://reviews.llvm.org/D129288>.  But an incremental fix separate from that would be okay.
>
> Not sure the extra flag carries its weight; it's already hard enough to keep track of all the various flags we put on MachineFunction , and you can already easily check IsInlineAsmBrIndirectTarget() while you're iterating over basic blocks.

I agree we should be careful to add more and more stuff into MachineFunction. Yes, using IsInlineAsmBrIndirectTarget() on all the basic blocks would achieve my purpose here as well. Thanks !

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129677/new/

https://reviews.llvm.org/D129677