[PATCH] D129677: Disable machine function splitting for functions with inline asm br

Wed Jul 13 14:15:33 PDT 2022

adriantong1024 added a comment.

In D129677#3649812 <https://reviews.llvm.org/D129677#3649812>, @efriedma wrote:

> In D129677#3649806 <https://reviews.llvm.org/D129677#3649806>, @efriedma wrote:
>
>>> The ones in the inline assembly cannot.
>>
>> This should be fixable on top of D129288 <https://reviews.llvm.org/D129288>.  But an incremental fix separate from that would be okay.
>
> Err, actually, now I'm confused.  What exactly do you mean by "recoded"?  Do you mean there's a rule that imposes a maximum distance between an INLINEASM_BR and its indirect destinations?  Is that rule written down anywhere?

In the inline assembly, there may be branch that can only jump a limited distance, if we run MFS on the function, the resulting distance maybe to far to encode into the instruction.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129677/new/

https://reviews.llvm.org/D129677