[PATCH] D129525: [GlobalOpt] Drop SRA split limit for struct types.

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 13 13:05:56 PDT 2022


nikic added a comment.

In D129525#3649499 <https://reviews.llvm.org/D129525#3649499>, @fhahn wrote:

> In D129525#3649361 <https://reviews.llvm.org/D129525#3649361>, @nikic wrote:
>
>> @fhahn I think your last update is missing the code changes :)
>
> I didn't make any code changes to the original version and it looks like the original code change is still there. Am I missing something? :)

Oh sorry, I misread your comment. I thought you wanted to add a check for nested arrays, but you were only referring to new tests.

> I think the main regression comes from SRA not removing stores of function pointers that are never read, which in turn prevents LLVM from removing those functions.

Okay, that's a particularly simple case. It's probably worthwhile to give skipping parts that are only stored a try, as we expect them to be dropped (it's not strictly guaranteed due to leak checker roots, but close enough). I can take a look.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129525/new/

https://reviews.llvm.org/D129525



More information about the llvm-commits mailing list