[PATCH] D117223: [GlobalOpt] Make global SRA offset based

[Florian Hahn via Phabricator via llvm-commits]

fhahn added inline comments.
Herald added a project: All.


================
Comment at: llvm/lib/Transforms/IPO/GlobalOpt.cpp:444
+  // Don't perform SRA if we would have to split into many globals.
+  if (Types.size() > 16)
+    return nullptr;
----------------
I think this limit is more aggressive for struct types than the original code AFAICT, which seems to be causing some code-size regressions. I put up D129525 to make the limit behave more like the original code.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117223/new/

https://reviews.llvm.org/D117223