[PATCH] D129637: [AMDGPU][MC][GFX11] Correct disassembly of *_e64_dpp opcodes which support op_sel

[Dmitry Preobrazhensky via Phabricator via llvm-commits]

dp added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/Disassembler/AMDGPUDisassembler.cpp:752
 
+static unsigned getOpSel(const MCInst &MI) {
+  unsigned Opc = MI.getOpcode();
----------------
Joe_Nash wrote:
> This is a very similar to the code in convertVOP3PDPP. Can we de-duplicate it and create a helper function that collects all modifier values?
Good point, thanks!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129637/new/

https://reviews.llvm.org/D129637