[PATCH] D129637: [AMDGPU][MC][GFX11] Correct disassembly of *_e64_dpp opcodes which support op_sel

Dmitry Preobrazhensky via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 13 06:03:17 PDT 2022


dp created this revision.
dp added reviewers: foad, Joe_Nash, Petar.Avramovic.
Herald added subscribers: kosarev, jsilvanus, kerbowa, hiraditya, t-tye, tpr, dstuttard, yaxunl, nhaehnle, jvesely, kzhuravl, arsenm.
Herald added a project: All.
dp requested review of this revision.
Herald added subscribers: llvm-commits, wdng.
Herald added a project: LLVM.

These opcodes cannot be disassembled because `op_sel` operand is missing - it must be added manually.
See bug 56512 <https://github.com/llvm/llvm-project/issues/56512> for detailed issue analysis.

A similar problem is being addressed in https://reviews.llvm.org/D129084, but it affects different opcodes.


https://reviews.llvm.org/D129637

Files:
  llvm/lib/Target/AMDGPU/Disassembler/AMDGPUDisassembler.cpp
  llvm/lib/Target/AMDGPU/Disassembler/AMDGPUDisassembler.h
  llvm/lib/Target/AMDGPU/VOPInstructions.td
  llvm/test/MC/Disassembler/AMDGPU/gfx11_dasm_vop3_dpp16.txt
  llvm/test/MC/Disassembler/AMDGPU/gfx11_dasm_vop3_dpp8.txt

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D129637.444237.patch
Type: text/x-patch
Size: 126715 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220713/3c2d8533/attachment-0001.bin>


More information about the llvm-commits mailing list