[PATCH] D129580: [PowerPC][LLD] Change the behavior of the PPC64R2SaveStub thunk.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 12 20:59:42 PDT 2022


MaskRay added a comment.

LG.

> `[PowerPC][LLD] Change the behavior of the PPC64R2SaveStub thunk.`

"Change the behavior" isn't descriptive. Just use a brief sentence to describe what has changed, e.g. "Change PPC64R2SaveStub to only use non-PC-relative code"



================
Comment at: lld/test/ELF/ppc64-toc-call-to-pcrel-long-jump.s:16
 # RUN: ld.lld -T %t/lts %t.o -o %t_le --no-power10-stubs
-# RUN: llvm-objdump --mcpu=pwr10 --no-show-raw-insn -d %t_le | FileCheck %s --check-prefix=NoP10
+# RUN: llvm-objdump --mcpu=pwr10 --no-show-raw-insn -d %t_le | FileCheck %s
 # RUN: llvm-readelf -s %t_le | FileCheck %s --check-prefix=SYM
----------------
Remove `--mcpu=pwr10` since llvm-objdump now defaults to --mcpu=future for ppc64.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129580/new/

https://reviews.llvm.org/D129580



More information about the llvm-commits mailing list